From ae74023b7293bf9ff0b94457b34fe2ebc70b73cc Mon Sep 17 00:00:00 2001 From: RD WebDesign Date: Sun, 28 Aug 2022 16:33:42 -0300 Subject: [PATCH] Add test to avoid "Undefined Variable" warnings Signed-off-by: RD WebDesign --- scripts/pi-hole/php/update_checker.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/pi-hole/php/update_checker.php b/scripts/pi-hole/php/update_checker.php index d47aafa64..020e88cbb 100644 --- a/scripts/pi-hole/php/update_checker.php +++ b/scripts/pi-hole/php/update_checker.php @@ -65,7 +65,11 @@ function checkUpdate($currentVersion, $latestVersion) $core_latest = $versions['GITHUB_CORE_VERSION']; $web_latest = $versions['GITHUB_WEB_VERSION']; $FTL_latest = $versions['GITHUB_FTL_VERSION']; - $docker_latest = $versions['GITHUB_DOCKER_VERSION']; + if (isset($versions['GITHUB_DOCKER_VERSION'])) { + $docker_latest = $versions['GITHUB_DOCKER_VERSION']; + } else { + $docker_latest = ''; + } // Version comparison if (!$docker_current) { @@ -73,6 +77,7 @@ function checkUpdate($currentVersion, $latestVersion) $core_update = checkUpdate($core_current, $core_latest); $web_update = checkUpdate($web_current, $web_latest); $FTL_update = checkUpdate($FTL_current, $FTL_latest); + $docker_update = false; } elseif ($docker_current == 'nightly' || $docker_current == 'dev') { // Special container - no update messages $docker_update = false;