Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News on Pi2.5 > vote/favorite/social css position #40

Open
Marc-pi opened this issue Dec 10, 2014 · 7 comments
Open

News on Pi2.5 > vote/favorite/social css position #40

Marc-pi opened this issue Dec 10, 2014 · 7 comments

Comments

@Marc-pi
Copy link
Member

Marc-pi commented Dec 10, 2014

  • improve their position, too close to text actually (add padding or a line)
  • favorite icon is not centered also
    news
@Marc-pi
Copy link
Member Author

Marc-pi commented Dec 24, 2014

r155

  • favorite icon is not centered still with social and favorite star
  • you wanted to reduce social bar sizes, no?

@voltan
Copy link
Member

voltan commented Dec 25, 2014

For social network size , I want use col-md-5 on all modules , what's is your idea ? this size is good?

@Marc-pi
Copy link
Member Author

Marc-pi commented Dec 25, 2014

well, do you have a demo somewhere so we can see the rendering with md-5?

@voltan
Copy link
Member

voltan commented Dec 25, 2014

At this moment on all modules :D

@Marc-pi
Copy link
Member Author

Marc-pi commented Dec 25, 2014

actually it is md-5 already ? i did not check, but smaller than it is on EDQ is needed.
perhaps can you change on cafeyab so we can check how smaller looks like

@voltan
Copy link
Member

voltan commented Dec 26, 2014

On EDQ and cafeyab , item templates use md-5 , other size needed ? for example md-4
cafeyab

@Marc-pi
Copy link
Member Author

Marc-pi commented Dec 27, 2014

r163

  • on news md4 is better. on guide, if you modify md4 it modifies also the image area.
  • rssb icon height needs to be reduces a little bit also, actually there is too much space between social network name and the border limit.
  • favorite icon is not centered still with social and favorite star
  • fix overlay in author page

theadmin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants