Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enum not correctly serialized with \http_build_query in guzzle #45

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

WoutervanderLoopNL
Copy link
Contributor

Query parameters are not correctly encoded when parameter is a enum:

current result:
page=1&fulfilment-method%5Bname%5D=FBR&fulfilment-method%5Bvalue%5D=FBR&status%5Bname%5D=OPEN&status%5Bvalue%5D=OPEN&change-interval-minute=1

  • parameter is encoded with the value and name property of the enum (which is PHP default) name=FBR&value=FBR . although I should expect a string enum is encoded to a string by default in PHP, but thats actually not the case.

expected result:
page=1&fulfilment-method=FBR&status=OPEN&change-interval-minute=1

@WoutervanderLoopNL
Copy link
Contributor Author

@casperbakker

@casperbakker casperbakker merged commit 04c7ad5 into picqer:main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants