Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for a card for lock domain #313

Closed
xBourner opened this issue Apr 14, 2022 · 16 comments
Closed

Request for a card for lock domain #313

xBourner opened this issue Apr 14, 2022 · 16 comments
Labels
enhancement New feature or request

Comments

@xBourner
Copy link

Hi i asked myself why no one made a "lock card".

I think it would look very cool and would fit better than an mushroom entity card.
Layout should be the same as the mushroom cover card.

You should have three buttons under the primary (and secondary) info.
The left one should be an unlock, the middle one a lock and the right one to open the lock.

Service calls would be lock.unlock (left), lock.lock (middle) and lock.open (right).
If the state of the lock is locked the middle button should be not accessible. Also the same for the left button when the lock is unlocked.

The way locks work with your mushroom entity card is great. It toggles the lock but i am not able to open the door without a service call from HA. So i think is quite a nice idea.

Please let me know what you think about. The other cards rock!

@xBourner xBourner added the enhancement New feature or request label Apr 14, 2022
@piitaya piitaya pinned this issue Apr 15, 2022
@piitaya piitaya unpinned this issue Apr 15, 2022
@NimlothPL
Copy link

Thanks for adding it - works great.

Some locks (like Tedee) have "open" action to pull string when lock is unlocked.
Can it be also added?

@piitaya
Copy link
Owner

piitaya commented Apr 15, 2022

Yep, it will be added in a next release 😉

@xBourner
Copy link
Author

Nice one. Thank you!

@acesyde
Copy link
Contributor

acesyde commented Apr 15, 2022

@NimlothPL can you share some screenshot about the standard HA card for your integration and can you share the state of this entity ? thk you :)

@xBourner
Copy link
Author

I got a Nuki. My standard card does not provide an „open action“ on default.
i added this with a button card which calls a service „lock.open“

@NimlothPL
Copy link

NimlothPL commented Apr 15, 2022

Yep, it will be added in a next release 😉

With your release speed then in like 5 minutes 🥇

@xBourner
Copy link
Author

is this update already the next release which should include lock.open action?

@acesyde
Copy link
Contributor

acesyde commented Apr 15, 2022

@xBourner Can you check the PR, I'm not sure about the unlocked state if the "open" icon should be here or not

@xBourner
Copy link
Author

@xBourner Can you check the PR, I'm not sure about the unlocked state if the "open" icon should be here or not

i would say open should be only available if the door is in unlocked state. otherwise you should need to unlock first.
anyway to have the control buttons on the bottom not the right?

@piitaya
Copy link
Owner

piitaya commented Apr 15, 2022

Yep, buttons position depends on the layout you choose for your card 🙂

@xBourner
Copy link
Author

ok i will wait for next release
looks good :)

@acesyde
Copy link
Contributor

acesyde commented Apr 15, 2022

@xBourner thks now the "open" button should be only visible when the state is "unlocked"

@piitaya
Copy link
Owner

piitaya commented Apr 15, 2022

It's released (1.6.1 version)

@piitaya piitaya closed this as completed Apr 15, 2022
@NimlothPL
Copy link

@piitaya just want to say thanks - it's perfect now 💯

@piitaya
Copy link
Owner

piitaya commented Apr 15, 2022

@acesyde did all the work for the lock card 😅

@NimlothPL
Copy link

@acesyde big thanks 🙏👍 awesome job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants