Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Optionally remove shape around icon and set icon size #385

Closed
teogira opened this issue Apr 23, 2022 · 12 comments
Closed

[Feature]: Optionally remove shape around icon and set icon size #385

teogira opened this issue Apr 23, 2022 · 12 comments
Labels
enhancement New feature or request

Comments

@teogira
Copy link

teogira commented Apr 23, 2022

Is your feature request related to a problem?

Icons are quite small for my 50 y.o. eyes

Describe the solution you'd like

If you don't want to render this parameters on UI, eventually you can include variables like: mush-shape-enabled and mush-icon-size into mushroom themes configuration.

Describe alternatives you've considered

No response

Additional context

No response

@teogira teogira added the enhancement New feature or request label Apr 23, 2022
@greghesp
Copy link
Contributor

greghesp commented Apr 23, 2022

Do you mean something like:

image

vs default:

image

@teogira
Copy link
Author

teogira commented Apr 23, 2022

Exactly.
I managed to obtain it by modifying mushroom.js file, but I wouldn't loss the changes after upgrading...

@acesyde
Copy link
Contributor

acesyde commented Apr 23, 2022

Do you want to do this for just one card are all cards ?

@greghesp
Copy link
Contributor

Do you want to do this for just one card are all cards ?

Probably best to enable for all cards but through theme options I'd have thought?

@teogira
Copy link
Author

teogira commented Apr 23, 2022

Better by theme options for all cards. Best by setting per-card UI option (in addition to theme)

@piitaya
Copy link
Owner

piitaya commented Apr 23, 2022

You can override theme variable with card-mod by defining them locally I think 🙂

@teogira
Copy link
Author

teogira commented Apr 23, 2022

@piitaya yes but card-mod is css-dependant and I wish a stable theme configuration.

@piitaya
Copy link
Owner

piitaya commented Apr 23, 2022

I will look to add additional theme variables 🙂

@teogira
Copy link
Author

teogira commented Apr 23, 2022

great!

@fenty17
Copy link

fenty17 commented May 2, 2022

Just adding my +1 to this. Not having any luck getting icon size changed with card-mod. I'd be happy if I could do that, but even better to have options/theme variables baked in.

@piitaya
Copy link
Owner

piitaya commented May 11, 2022

New variables have been added to allow you customize the sizes of slider, icon and control with theme variables 🙂https://github.com/piitaya/lovelace-mushroom/releases/tag/v1.8.1

@piitaya piitaya closed this as completed May 11, 2022
@teogira
Copy link
Author

teogira commented May 15, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants