Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Improve fan slider #517

Closed
redphx opened this issue May 23, 2022 · 6 comments · Fixed by #521
Closed

[Feature]: Improve fan slider #517

redphx opened this issue May 23, 2022 · 6 comments · Fixed by #521
Labels
enhancement New feature or request

Comments

@redphx
Copy link
Contributor

redphx commented May 23, 2022

Is your feature request related to a problem?

My fan only has 3 speeds: 33%, 66% and 100%. Currently it's difficult to select the correct speed, as you can see in this GIF:

fan

Describe the solution you'd like

Instead of having 1% as threshold, it should be 33% instead (for my case). I found a similar example written in Vue: https://jsfiddle.net/qkuLdjt9/ (not the best example but you get the idea).

slide

I think we can achieve this with Hammer.js too (not tested yet)

Describe alternatives you've considered

No response

Additional context

No response

@redphx redphx added the enhancement New feature or request label May 23, 2022
@piitaya
Copy link
Owner

piitaya commented May 23, 2022

Hello 🙂 What's your fan integration? 🙂

@redphx
Copy link
Contributor Author

redphx commented May 23, 2022

I'm using a Xiaomi Fan 1C with https://github.com/syssi/xiaomi_airpurifier.
Here are some attributes of the fan

preset_modes: off, Level 1, Level 2, Level 3
oscillating: true
percentage: 66
percentage_step: 33.333333333333336
preset_mode: Level 2
model: dmaker.fan.p8

@piitaya
Copy link
Owner

piitaya commented May 23, 2022

What's more-info slider behavior ? 🙂

@redphx
Copy link
Contributor Author

redphx commented May 23, 2022

Did you mean this?

image

I tried to change it to "No Action" and it's still the same as before.

@piitaya
Copy link
Owner

piitaya commented May 23, 2022

image
Does this slider work for all speed of your fan ?

@redphx
Copy link
Contributor Author

redphx commented May 23, 2022

Yes it does. The slider works exactly like I wanted to.
slide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants