Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display picture in person entity chip #61

Closed
cyrilphoenix71 opened this issue Feb 7, 2022 · 8 comments · Fixed by #393
Closed

Display picture in person entity chip #61

cyrilphoenix71 opened this issue Feb 7, 2022 · 8 comments · Fixed by #393
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cyrilphoenix71
Copy link

Add option to show person picture in chips person card would be better

@bemble bemble added the wontfix This will not be worked on label Feb 7, 2022
@bemble
Copy link
Collaborator

bemble commented Feb 7, 2022

You can add a badge for this ;)

@bemble bemble closed this as completed Feb 7, 2022
@cyrilphoenix71
Copy link
Author

I'm not sur to understand, can you explain a bit more ?

@bemble
Copy link
Collaborator

bemble commented Feb 8, 2022

Sorry I was wrong on a point, you cannot hide name etc on person badge. We discussed with @piitaya about the ability to use card without background, border, padding and shadow (ie. what makes a card, a card). We have no plane for this at all, I'll explain why in one of your other issue.

@cyrilphoenix71
Copy link
Author

No problem don't worry :) may be my issue is not clear. What I suggest it's just a little things
Actualy in chips card, by defaut a person chips is add, we can custom it with a icon.
My suggest is to have the possibility to use the profil picture instead icon like the person card option

@bemble bemble reopened this Feb 9, 2022
@bemble
Copy link
Collaborator

bemble commented Feb 9, 2022

@piitaya ?

@bemble bemble changed the title Option Chrips person card Display picture in person entity chip Feb 9, 2022
@piitaya
Copy link
Owner

piitaya commented Feb 9, 2022

There is no person-chip for now. Maybe we can add it in the future but I don't think we must add a picture option in entity chip

@bemble
Copy link
Collaborator

bemble commented Feb 9, 2022

There is no person-chip for now. Maybe we can add it in the future but I don't think we must add a picture option in entity chip

You can add a entity chip with the person entity. That's also my opinion for the picture.

@bemble bemble added enhancement New feature or request and removed wontfix This will not be worked on labels Feb 14, 2022
@bemble bemble added this to the 1.2.0 milestone Feb 14, 2022
@bemble bemble self-assigned this Feb 14, 2022
@bemble
Copy link
Collaborator

bemble commented Feb 14, 2022

I'll create a person chip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants