Error out if nsswitch.conf specifies merge action. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merge action isn't dealt with properly (it's mostly treated as a return action), so we shouldn't pretend it is. Instead of removing it completely, error out clearly and leave room for it being implemented fully in the future.
We have already fixed main.c so any config files specifying the merge action are rejected. Having ACT_MERGE here was wrong; its behavior requires manually appending together the contents of struct passwd or struct group; just writing it out ends up making ACT_MERGE exactly equivalent to ACT_RETURN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge action isn't dealt with properly (it's mostly treated as a
return action), so we shouldn't pretend it is. Instead of removing it
completely, error out clearly and leave room for it being implemented
fully in the future.