Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotkey setting box focus prevents hotkeys from being set properly #16

Open
paulitepsa opened this issue Jan 12, 2025 · 2 comments · May be fixed by #17
Open

Hotkey setting box focus prevents hotkeys from being set properly #16

paulitepsa opened this issue Jan 12, 2025 · 2 comments · May be fixed by #17

Comments

@paulitepsa
Copy link

The hotkey boxes never release focus, which prevents hotkeys from being set (tested on Garuda Linux with KDE).
I fixed this on my end by adding hotkey_box.clearFocus() in ui_controller.py at row 1669.
pilgrimtabby added a commit that referenced this issue Jan 12, 2025
@pilgrimtabby
Fix bug (#16) preventing setting hotkeys sometimes
5d386cf 
Hotkey boxes wouldn't lose focus when pressing a key, preventing them from being set on some versions (caught on Garuda Linux with KDE). This change fixes this. Thanks to @paulitepsa for finding and fixing this!
@pilgrimtabby pilgrimtabby linked a pull request Jan 12, 2025 that will close this issue
Fix bug (#16) preventing setting hotkeys sometimes #17
Open
@pilgrimtabby
Copy link
Owner

Thanks for the issue! Does this pull request (#17) do what you're describing? I tested the change on my computer (MacOS Ventura) and it seems to be working. If it looks right to you, I'll go ahead and merge it.

@paulitepsa
Copy link
Author

paulitepsa commented Jan 12, 2025 •
edited
Loading

Yup, that looks right :)
You're welcome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug (#16) preventing setting hotkeys sometimes pilgrimtabby/pilgrim-autosplitter
2 participants
@paulitepsa @pilgrimtabby