Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pydantic validation needs to be adapted for Pydantic v2 #247

Closed
pilosus opened this issue Sep 22, 2023 · 0 comments · Fixed by #248
Closed

Pydantic validation needs to be adapted for Pydantic v2 #247

pilosus opened this issue Sep 22, 2023 · 0 comments · Fixed by #248
Assignees
@pilosus

Comments

@pilosus
Copy link
Owner

pilosus commented Sep 22, 2023

Describe the bug

  • Tests fail as Pydantic v2 changed error messages and regexp don't work anymore
  • Pydantic v2 deprecates dict() method in favour of model_dump()

See more details in migration guide

To Reproduce

  • make install
  • make test

Expected behavior

Pydantic v1 and v2 are supported

Context

  • Piny develop version
@pilosus pilosus self-assigned this Sep 22, 2023
@pilosus pilosus mentioned this issue Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilosus pilosus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Pydantic v2 pilosus/piny
1 participant
@pilosus