Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spruce workflows and references to release in version.json #195

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

austin-denoble
Copy link
Contributor

Problem

There are build issues because I removed the release field from version.json, but it's being accessed in buildUserAgent().

release was specific to spruce and we can remove these workflows completely at this point, along with the references to release.

Solution

  • Remove release-spruce and release-spruce-dev workflows.
  • Remove checking release from version.json.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Test Plan

Validate CI and client builds properly.

@austin-denoble austin-denoble requested a review from jhamon January 17, 2024 16:18
@austin-denoble austin-denoble merged commit cd0052d into main Jan 17, 2024
26 checks passed
@austin-denoble austin-denoble deleted the adenoble/fix-user-agent branch January 17, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants