Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/tidb-lightning: update docs for 3.0.2 and master #1455

Merged
merged 18 commits into from
Sep 12, 2019
Merged

tools/tidb-lightning: update docs for 3.0.2 and master #1455

merged 18 commits into from
Sep 12, 2019

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Aug 14, 2019

What is changed, added or deleted?

  1. Updated download links to 3.0.2 and 2.1.14.
  2. Documented the web interface for master version.
  3. Documented the Grafana dashboard.
  4. Reorganized the "deployment" page --- the full configuration is now moved into a dedicated "configuration" page, while the "deployment" only contains the essential configuration to simplify the steps.
  5. The new "configuration" page also describes the CLI parameters of the associated tools.

What is the related PR or file link(s)?

Which version does your change affect?

  • dev

I'd copy the change to v3.0 and v2.1 if deemed useful.

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

@kennytm kennytm force-pushed the kennytm/lightning-2019-08 branch 2 times, most recently from 721b730 to cda192b Compare August 14, 2019 04:46
@kennytm kennytm force-pushed the kennytm/lightning-2019-08 branch from cda192b to 37faa47 Compare August 14, 2019 07:53
@lilin90 lilin90 requested review from lilin90 and IANTHEREAL August 19, 2019 08:09
lilin90
lilin90 reviewed Aug 26, 2019
View reviewed changes
dev/reference/tools/tidb-lightning/config.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/config.md Show resolved Hide resolved
dev/reference/tools/tidb-lightning/config.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/config.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/config.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Aug 26, 2019
View reviewed changes
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Show resolved Hide resolved
@lilin90
Copy link
Member

lilin90 commented Sep 2, 2019

@GregoryIan PTAL

@IANTHEREAL
Copy link
Contributor

please resolve conflicts @kennytm

@IANTHEREAL
Copy link
Contributor

Rest LGTM

lilin90
lilin90 approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm
Copy link
Contributor Author

kennytm commented Sep 5, 2019 •
edited
Loading

PTAL @GregoryIan

@lilin90
Copy link
Member

lilin90 commented Sep 5, 2019

@GregoryIan @kennytm Do we need to add the new files in this PR to v3.0 and v2.1?

@lilin90 lilin90 added the translation/doing This PR's assignee is translating this PR. label Sep 5, 2019
@kennytm
Copy link
Contributor Author

kennytm commented Sep 9, 2019

Ping @GregoryIan. I'll copy the changes to v3.0 if it's OK. I don't think we wanna touch v2.1.

@IANTHEREAL
Copy link
Contributor

Rest LGTM

lilin90
lilin90 reviewed Sep 11, 2019
View reviewed changes
dev/reference/tools/tidb-lightning/config.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/config.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/config.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/web.md Outdated Show resolved Hide resolved
@kennytm
Copy link
Contributor Author

kennytm commented Sep 11, 2019

PTAL @lilin90 (@yikeke ?) f30f213

@IANTHEREAL
Copy link
Contributor

LGTM

@IANTHEREAL IANTHEREAL merged commit 01e5e9d into master Sep 12, 2019
@IANTHEREAL IANTHEREAL deleted the kennytm/lightning-2019-08 branch September 12, 2019 06:00
@kennytm kennytm mentioned this pull request Oct 16, 2019
Merged
@yikeke yikeke assigned anotherrachel and unassigned yikeke Oct 17, 2019
@anotherrachel anotherrachel mentioned this pull request Oct 29, 2019
Merged
@anotherrachel anotherrachel added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. dev and removed translation/doing This PR's assignee is translating this PR. labels Oct 29, 2019
@TomShawn TomShawn mentioned this pull request Nov 18, 2019
Merged
@anotherrachel anotherrachel mentioned this pull request Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

Assignees

@anotherrachel anotherrachel

Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennytm @lilin90 @IANTHEREAL @yikeke @anotherrachel