Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: Update sql mode default #11

Merged
merged 5 commits into from
Nov 7, 2018
Merged

mysql: Update sql mode default #11

merged 5 commits into from
Nov 7, 2018

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Nov 2, 2018

This PR updates the SQL Mode to include only_full_group by and no_auto_create_user.

It fixes pingcap/tidb#8129 and partially addresses pingcap/tidb#8128

It depends on: pingcap/tidb#8163

@morgo morgo changed the title mysql: Update sql mode default [WIP] mysql: Update sql mode default Nov 2, 2018
@morgo morgo added the DNM label Nov 2, 2018
@morgo morgo changed the title [WIP] mysql: Update sql mode default mysql: Update sql mode default Nov 3, 2018
@morgo morgo removed the DNM label Nov 3, 2018
@morgo morgo requested a review from tiancaiamao November 3, 2018 12:25
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Nov 5, 2018

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Nov 5, 2018
@tiancaiamao
Copy link
Collaborator

LGTM

@tiancaiamao tiancaiamao added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Nov 7, 2018
@tiancaiamao tiancaiamao merged commit f0db1d1 into pingcap:master Nov 7, 2018
@morgo morgo deleted the update-sql-mode branch November 7, 2018 22:21
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
* mysql: Add NO_AUTO_CREATE_USER detection
* mysql: Update Default SQL Mode
* Include No_auto_create_user and only_full_group_by
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
* mysql: Add NO_AUTO_CREATE_USER detection
* mysql: Update Default SQL Mode
* Include No_auto_create_user and only_full_group_by
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable sql-mode ONLY_FULL_GROUP_BY by default
5 participants