Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add Not flag for ExistsSubqueryExpr #391

Merged
merged 1 commit into from
Jul 17, 2019
Merged

*: add Not flag for ExistsSubqueryExpr #391

merged 1 commit into from
Jul 17, 2019

Conversation

eurekaka
Copy link
Contributor

Parser part of the cherry-pick for pingcap/tidb#7842

@eurekaka
*: add Not flag for ExistsSubqueryExpr
c663361 
Parser part of the cherry-pick for pingcap/tidb#7842
@CLAassistant
Copy link

CLAassistant commented Jul 17, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@eurekaka eurekaka requested review from alivxxx, zz-jason and winoros July 17, 2019 12:04
@eurekaka eurekaka mentioned this pull request Jul 17, 2019
Merged
zz-jason
zz-jason reviewed Jul 17, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 LGT1 label Jul 17, 2019
alivxxx
alivxxx approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Jul 17, 2019
@alivxxx alivxxx merged commit 366176d into pingcap:release-2.1 Jul 17, 2019
@eurekaka eurekaka deleted the pick_antijoin branch July 18, 2019 03:33
@eurekaka eurekaka mentioned this pull request Jul 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@alivxxx alivxxx alivxxx approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
status/LGT2 LGT2 type/cherry-pick-for-release-2.1 type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eurekaka @CLAassistant @zz-jason @alivxxx