-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: fix GetHotStores #1487
Merged
Merged
api: fix GetHotStores #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1487 +/- ##
==========================================
+ Coverage 67.2% 67.37% +0.16%
==========================================
Files 158 158
Lines 15385 15385
==========================================
+ Hits 10339 10365 +26
+ Misses 4107 4084 -23
+ Partials 939 936 -3
Continue to review full report at Codecov.
|
LGTM. |
hicqu
approved these changes
Mar 29, 2019
nolouch
approved these changes
Mar 29, 2019
bradyjoestar
added a commit
to bradyjoestar/pd
that referenced
this pull request
Mar 30, 2019
fix get hot store (tikv#1487)
nolouch
added
the
needs-cherry-pick-release-2.1
The PR needs to cherry pick to release-2.1 branch.
label
Mar 31, 2019
bradyjoestar
added a commit
to bradyjoestar/pd
that referenced
this pull request
Apr 1, 2019
fix get hot store (tikv#1487)
nolouch
pushed a commit
to nolouch/pd
that referenced
this pull request
Apr 2, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently,
GetHotStores
will return the same value forKeysRead
andKeysWritten
.What is changed and how it works?
This PR fixes this problem and improves the test.
Check List
Tests