Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: add tso handle time metrics #1502

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

When pd-client reports slow tso, we don't know if it takes too much time for server to handle the request.

What is changed and how it works?

Add metrics.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the tidb-ansible repository

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. label Apr 11, 2019
@codecov-io
Copy link

Codecov Report

Merging #1502 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   67.45%   67.36%   -0.09%     
==========================================
  Files         158      158              
  Lines       15518    15521       +3     
==========================================
- Hits        10467    10456      -11     
- Misses       4109     4113       +4     
- Partials      942      952      +10
Impacted Files Coverage Δ
server/metrics.go 100% <100%> (ø) ⬆️
server/grpc_service.go 50.99% <100%> (+0.21%) ⬆️
server/util.go 70.27% <0%> (-7.44%) ⬇️
server/etcd_kv.go 63.63% <0%> (-7.28%) ⬇️
server/leader.go 78.57% <0%> (-6.31%) ⬇️
server/api/redirector.go 78.94% <0%> (-5.27%) ⬇️
server/handler.go 55.06% <0%> (-0.52%) ⬇️
client/client.go 68.29% <0%> (-0.24%) ⬇️
server/tso.go 72.72% <0%> (+3.4%) ⬆️
server/region_syncer/server.go 81.89% <0%> (+3.44%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba0e44...1a13a3c. Read the comment docs.

@rleungx rleungx merged commit 656a830 into tikv:master Apr 12, 2019
disksing added a commit to oh-my-tidb/pd that referenced this pull request Apr 12, 2019
Signed-off-by: disksing <i@disksing.com>
disksing added a commit to oh-my-tidb/pd that referenced this pull request Apr 12, 2019
Signed-off-by: disksing <i@disksing.com>
nolouch pushed a commit that referenced this pull request Apr 12, 2019
Signed-off-by: disksing <i@disksing.com>
@disksing disksing deleted the tso-metrics branch September 23, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants