metrics: add storeID to metrics back #1506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#1429 uses the address to replace
storeID
in metrics, but sincepd-ctl
usesstoreID
to execute the store related command, it's not convenient for us to trace the problem. Another problem is when a store becomes tombstone, and add it back with the same address, the reset metrics function will reset this address. So it is better to addstoreID
back.What is changed and how it works?
This PR adds
storeID
to metrics back.Check List
Tests
Related changes
tidb-ansible
repository