placement: add API support #1894
Conversation
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Codecov Report
@@ Coverage Diff @@
## master #1894 +/- ##
==========================================
- Coverage 78.08% 77.32% -0.76%
==========================================
Files 163 164 +1
Lines 16338 16468 +130
==========================================
- Hits 12757 12734 -23
- Misses 2583 2725 +142
- Partials 998 1009 +11
Continue to review full report at Codecov.
|
|
@lhy1024 I think we need the test. But I don't have enough time to add it now.. |
server/api/rule.go
Outdated
| return | ||
| } | ||
| if !cluster.IsPlacementRulesEnabled() { | ||
| h.rd.JSON(w, http.StatusPreconditionFailed, "placement rules feature is disabled") |
There was a problem hiding this comment.
How about defining an error?
Signed-off-by: disksing <i@disksing.com>
There was a problem hiding this comment.
I think we could introduce the Middleware to reduce the duplicated code.
In ideal, we should define two middlewares, one for bootstrapping, another for placement rules. However, the bootstrapping middleware has no relationship with this PR, maybe we can combine these middlewares into single one first, and leave the TODOs to future refactoring or as PCP problem.
| if !cluster.IsPlacementRulesEnabled() { | ||
| h.rd.JSON(w, http.StatusPreconditionFailed, placementDisabledErr.Error()) | ||
| return | ||
| } |
There was a problem hiding this comment.
It is really verbose of these lines of code. Maybe you want to try the middleware https://github.com/gorilla/mux#middleware
There was a problem hiding this comment.
I'll see what I can do for now.
Signed-off-by: disksing <i@disksing.com> Co-Authored-By: Shafreeck Sea <shafreeck@users.noreply.github.com>
Signed-off-by: disksing <i@disksing.com> Co-Authored-By: Shafreeck Sea <shafreeck@users.noreply.github.com>
nolouch
added
the
status/can-merge
|
/run-all-tests |
What problem does this PR solve?
continue merge placement rules.
What is changed and how it works?
Check List
Tests
Code changes