placement: add FitRegion implementation #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
=========================================
+ Coverage 77.33% 78.1% +0.76%
=========================================
Files 165 167 +2
Lines 16590 16613 +23
=========================================
+ Hits 12830 12975 +145
+ Misses 2750 2644 -106
+ Partials 1010 994 -16
Continue to review full report at Codecov.
|
shafreeck
reviewed
Nov 6, 2019
lhy1024
reviewed
Nov 7, 2019
| for _, rule := range rules { | ||
| rf := fitRule(peers, rule) | ||
| regionFit.RuleFits = append(regionFit.RuleFits, rf) | ||
| // Remove selected. |
There was a problem hiding this comment.
does it mean there is only one rule in a range?
There was a problem hiding this comment.
Not really. There can be multiple rules in a range, i.e. multiple rules for a region.
Remove selected here is because a peer can only belong to a Rule.
Signed-off-by: disksing <i@disksing.com> Co-Authored-By: lhy1024 <admin@liudos.us>
nolouch
reviewed
Nov 7, 2019
Signed-off-by: disksing <i@disksing.com>
nolouch
reviewed
Nov 7, 2019
rleungx
reviewed
Nov 7, 2019
Signed-off-by: disksing <i@disksing.com>
nolouch
approved these changes
Nov 7, 2019
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
continue merging placement rules.
What is changed and how it works?
add FitRegion implementation
Check List
Tests