Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: update the region cache when flow changed (#1759) (#1741) (#1641) #2103

Merged
merged 3 commits into from
Jan 19, 2020
Merged

cluster: update the region cache when flow changed (#1759) (#1741) (#1641) #2103

merged 3 commits into from
Jan 19, 2020

Conversation

HunDunDM
Copy link
Member

Signed-off-by: hundundm hundundm@gmail.com

What problem does this PR solve?

cherry-pick #1759 #1741 and part of #1641

Check List

Tests

  • Unit test

@HunDunDM HunDunDM requested review from nolouch, rleungx, disksing and lhy1024 and removed request for nolouch, rleungx and disksing January 19, 2020 05:23
@HunDunDM HunDunDM added this to the v3.0.10 milestone Jan 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #2103 into release-3.0 will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-3.0   #2103      +/-   ##
==============================================
+ Coverage        69.65%   69.7%   +0.05%     
==============================================
  Files              170     170              
  Lines            16802   16825      +23     
==============================================
+ Hits             11703   11728      +25     
- Misses            4129    4132       +3     
+ Partials           970     965       -5
Impacted Files Coverage Δ
server/core/region.go 93.61% <100%> (+0.11%) ⬆️
server/core/region_option.go 83.8% <100%> (+0.98%) ⬆️
server/cluster_info.go 89.35% <100%> (+1.27%) ⬆️
server/api/region.go 69.06% <100%> (+0.26%) ⬆️
server/metrics.go 100% <100%> (ø) ⬆️
pkg/testutil/operator_check.go 83.33% <0%> (-16.67%) ⬇️
server/region_syncer/client.go 81.57% <0%> (-3.95%) ⬇️
server/tso.go 74.46% <0%> (-2.13%) ⬇️
server/util.go 70.7% <0%> (-1.92%) ⬇️
server/grpc_service.go 58.2% <0%> (-0.64%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488afe4...44bae1e. Read the comment docs.

@lhy1024
Copy link
Contributor

lhy1024 commented Jan 19, 2020

/run-all-tests

nolouch
nolouch approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rleungx
rleungx approved these changes Jan 19, 2020
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HunDunDM
Copy link
Member Author

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 19, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 19, 2020

/run-all-tests

@sre-bot sre-bot merged commit 5cf2711 into tikv:release-3.0 Jan 19, 2020
@HunDunDM HunDunDM deleted the fix-written-keys-3.0 branch July 28, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@nolouch nolouch nolouch approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HunDunDM @codecov-io @lhy1024 @sre-bot @nolouch @rleungx