Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: make api/version and release version consistent (#2191) #2192

Merged
merged 5 commits into from
Mar 5, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 4, 2020

cherry-pick #2191 to release-3.1


Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Fix problem

curl http://pd-ip:2379/api/v1/version

got:  1.0.0

What is changed and how it works?

consistent with the release version.

Check List

Tests

  • Unit test

Signed-off-by: nolouch <nolouch@gmail.com>
@@ -3,6 +3,7 @@ package api
import (
"net/http"

"github.com/pingcap/pd/v4/server"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 should be changed

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor

nolouch commented Mar 4, 2020

/run-all-tests

@nolouch nolouch added this to the v3.1.0-rc milestone Mar 4, 2020
@zyxbest
Copy link

zyxbest commented Mar 5, 2020

/run-all-tests

nolouch added 2 commits March 5, 2020 18:51
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor

nolouch commented Mar 5, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 5, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 5, 2020

/run-all-tests

@sre-bot sre-bot merged commit bf609e4 into tikv:release-3.1 Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants