Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdctl: add placement rules commands #2306

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Apr 1, 2020

What problem does this PR solve?

cherry-pick #2293

What is changed and how it works?

add commands:

  • pd-ctl config placement-rules enable, same as config set enable placement-rules true
  • pd-ctl config placement-rules disable, same as config set enable placement-rules false
  • pd-ctl config placement-rules show, show all rules
  • pd-ctl config placement-rules show --group=g1, show rules in a group
  • pd-ctl config placement-rules show --group=g1 --id=id2, show a rule
  • pd-ctl config placement-rules show --region=1, show rules match a region
  • pd-ctl config placement-rules load -out=rules.json, load all rules to a file
  • pd-ctl config placement-rules save -in=rules.json, save rules in a file to PD

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Check List

Tests

  • Unit test

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn: TBD

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added this to the v3.1.0-rc milestone Apr 1, 2020
@disksing disksing requested review from nolouch, lhy1024 and rleungx April 1, 2020 03:04
@lhy1024
Copy link
Contributor

lhy1024 commented Apr 1, 2020

/run-all-tests

Signed-off-by: disksing <i@disksing.com>
@disksing
Copy link
Contributor Author

disksing commented Apr 1, 2020

/run-all-tests

@nolouch
Copy link
Contributor

nolouch commented Apr 1, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 1, 2020

/run-all-tests

@sre-bot sre-bot merged commit cbcbea0 into tikv:release-3.1 Apr 1, 2020
@disksing disksing deleted the pick2293 branch August 28, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants