api: fix the certificate problem in API client #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
|
/rebuid |
rleungx
reviewed
Apr 21, 2020
| var ( | ||
|
|
||
| // dialClient used to dial http request. | ||
| dialClient = cluster.DialClient |
There was a problem hiding this comment.
The client in cluster package has a timeout. Does the client in API need it?
There was a problem hiding this comment.
I checked it and it only used in a redirect for the scheduler handler, I think it's ok to timeout.
There was a problem hiding this comment.
If we use API to get all regions and the region number is large, will it break the process of getting regions?
There was a problem hiding this comment.
the client in the user, not in PD. and if request to the follower, the redirected client is in the pkg/apiutil/serverapi, that's already supports TLS.
|
/rebuild |
1 similar comment
|
/rebuild |
rleungx
approved these changes
Apr 21, 2020
lhy1024
approved these changes
Apr 21, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/merge |
1 similar comment
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Fix #2362
What is changed and how it works?
add TLS supports for the client.
Release note
Check List
Tests