-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: fix the encoded path of region key #2399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
fix-region-key-match
branch
from
May 7, 2020 06:45
b6a1c28
to
f188061
Compare
HunDunDM
approved these changes
May 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
nolouch
approved these changes
May 8, 2020
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
May 8, 2020
/run-all-tests |
nolouch
added
needs-cherry-pick-release-3.0
The PR needs to cherry pick to release-3.0 branch.
needs-cherry-pick-release-3.1
The PR needs to cherry pick to release-3.1 branch.
labels
Jun 24, 2020
cherry pick to release-3.0 failed |
cherry pick to release-3.1 in PR #2575 |
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Jun 24, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-srebot
added a commit
that referenced
this pull request
Jun 24, 2020
ti-srebot
pushed a commit
that referenced
this pull request
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/api
HTTP API.
needs-cherry-pick-release-3.0
The PR needs to cherry pick to release-3.0 branch.
needs-cherry-pick-release-3.1
The PR needs to cherry pick to release-3.1 branch.
status/can-merge
Indicates a PR has been approved by a committer.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the
404
problem when using region key in pd-ctl, which is mentioned in #2351.What is changed and how it works?
This PR uses
UseEncodedPath
to solve the%2F
problem.Release note
Fix the
404
problem when usingregion key
in pd-ctlCheck List
Tests