config: resolve data path to absolute directory #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Breezewish <me@breeswish.org>
HunDunDM
approved these changes
May 14, 2020
|
/run-all-tests |
nolouch
approved these changes
May 14, 2020
|
/merge |
1 similar comment
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@breeswish merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Breezewish me@breeswish.org
What problem does this PR solve?
This PR resolves data path to an absolute directory, like what TiKV did.
This make PD instance to display correctly in TiDB Dashboard since TiDB Dashboard uses the data-directory to determine which disk information need to be displayed. Other paths are untouched for now.
What is changed and how it works?
Resolve to absolute directory in config adjust.
Check List
Tests
Manual test : After this change TiDB Dashboard becomes normal
Need to cherry-pick to the release branch
Release note
Resolve data directory to absolute path.