Cherry pick #2454 to release-4.0 #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
|
/run-all-tests |
lhy1024
approved these changes
May 26, 2020
Signed-off-by: Breezewish <me@breeswish.org>
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2457 +/- ##
===============================================
+ Coverage 76.42% 76.99% +0.56%
===============================================
Files 206 205 -1
Lines 21958 21936 -22
===============================================
+ Hits 16782 16889 +107
+ Misses 3905 3752 -153
- Partials 1271 1295 +24
Continue to review full report at Codecov.
|
|
/run-all-tests |
nolouch
approved these changes
May 26, 2020
HunDunDM
approved these changes
May 26, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cherry pick #2454 to release-4.0
What is changed and how it works?
TiDB Dashboard.
Check List
Tests
Release note
Support setting public path for the embedded Dashboard.