Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedulers: fix hot region scheduler (#2618) #2627

Merged
merged 2 commits into from
Jul 14, 2020
Merged

schedulers: fix hot region scheduler (#2618) #2627

merged 2 commits into from
Jul 14, 2020

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 10, 2020 •
edited by lhy1024
Loading

cherry-pick #2618 to release-4.0

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

Expectation filter store did not take effect

Check List

Tests

  • Unit test

Release note

  • Fix dst store filter in hot region scheduler

@lhy1024 @ti-srebot
fix hot region scheduler
05486f7 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 @ti-srebot
fix test
cae1e10 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-srebot ti-srebot mentioned this pull request Jul 10, 2020
Merged
@ti-srebot ti-srebot added component/scheduler Scheduler logic. require-LGT1 Indicates that the PR requires an LGTM. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick labels Jul 10, 2020
@ti-srebot ti-srebot added this to the v4.0.3 milestone Jul 10, 2020
@ti-srebot
Copy link
Contributor Author

@lhy1024 please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/pd/invitations

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 10, 2020

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 10, 2020

LGTM

@ti-srebot
Copy link
Contributor Author

@lhy1024,Thanks for your review.

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 10, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 10, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2627 into release-4.0 will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2627      +/-   ##
===============================================
+ Coverage        77.21%   77.48%   +0.26%     
===============================================
  Files              205      205              
  Lines            22117    22119       +2     
===============================================
+ Hits             17078    17138      +60     
+ Misses            3742     3667      -75     
- Partials          1297     1314      +17
Impacted Files Coverage Δ
server/schedulers/hot_region.go 82.36% <100.00%> (+0.04%) ⬆️
pkg/dashboard/adapter/manager.go 80.18% <0.00%> (-13.21%) ⬇️
pkg/etcdutil/etcdutil.go 78.26% <0.00%> (-10.15%) ⬇️
pkg/metricutil/metricutil.go 86.11% <0.00%> (-8.34%) ⬇️
server/member/lease.go 92.18% <0.00%> (-3.13%) ⬇️
server/member/leader.go 72.37% <0.00%> (-1.95%) ⬇️
server/region_syncer/client.go 84.73% <0.00%> (-1.53%) ⬇️
server/handler.go 50.53% <0.00%> (-0.44%) ⬇️
server/grpc_service.go 59.07% <0.00%> (+0.38%) ⬆️
server/schedule/operator_controller.go 82.09% <0.00%> (+0.67%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fe970...cae1e10. Read the comment docs.

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 10, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

HunDunDM
HunDunDM approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2020
@ti-srebot
Copy link
Contributor Author

@HunDunDM,Thanks for your review.

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 13, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

rleungx
rleungx approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 13, 2020
@ti-srebot
Copy link
Contributor Author

@rleungx,Thanks for your review.

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 13, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@nolouch
Copy link
Contributor

nolouch commented Jul 13, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 14, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2629

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 14, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2635

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 14, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit bfc9f3a into tikv:release-4.0 Jul 14, 2020
@lhy1024 lhy1024 added the type/bugfix This PR fixes a bug. label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

Assignees

@lhy1024 lhy1024

Labels
component/scheduler Scheduler logic. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v4.0.3
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @lhy1024 @codecov-commenter @nolouch @HunDunDM @rleungx