-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service: Fix the issue that cannot update only TTL of the min service safepoint (#2633) #2635
service: Fix the issue that cannot update only TTL of the min service safepoint (#2633) #2635
Conversation
…vice safepoint Signed-off-by: MyonKeminta <mk@mkmkm.me>
@MyonKeminta please accept the invitation then you can push to the cherry-pick pull requests. |
/merge |
/run-all-tests |
@ti-srebot merge failed. |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
/merge |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2635 +/- ##
===============================================
- Coverage 77.11% 77.05% -0.06%
===============================================
Files 205 205
Lines 22115 22115
===============================================
- Hits 17053 17041 -12
- Misses 3761 3769 +8
- Partials 1301 1305 +4
Continue to review full report at Codecov.
|
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
cherry-pick #2633 to release-4.0
What problem does this PR solve?
Fixes #2628
Do not skip updating service safepoint when the requested safepoint equals to the minimum safepoint currently.
What is changed and how it works?
Check List
Tests
Related changes
Release note