server: Fix the bug that infinite TTL for service safepoint doesn't work (#3138) #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
HunDunDM
approved these changes
Nov 4, 2020
lhy1024
approved these changes
Nov 4, 2020
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository. |
ti-chi-bot
added
the
status/can-merge
|
Can merge label has been added. Git tree hash: b2135a6
|
|
/run-integration-ddl-test |
|
/merge |
|
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository. |
rleungx
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #3138 to release-4.0
Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com
Fix infinite TTL doesn't work
Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com
What problem does this PR solve?
Fixes #3128
What is changed and how it works?
In the original code the expire time of service safepoints are calculated by
time.Unit() + TTL, and we use MaxInt64 to represent infinite TTL. Then it overflows to a minus value and expires immediately. This PR fixes the issue.Check List
Tests
Code changes
Side effects
Related changes
Release note