-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: grafana dashboards support multiple cluster (#3389) #3398
metrics: grafana dashboards support multiple cluster (#3389) #3398
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
@zjj2wry please accept the invitation then you can push to the cherry-pick pull requests. |
@zjj2wry, please resolve the conflict. |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3398 +/- ##
===============================================
- Coverage 74.71% 74.66% -0.06%
===============================================
Files 209 209
Lines 19737 19737
===============================================
- Hits 14747 14736 -11
- Misses 3650 3665 +15
+ Partials 1340 1336 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/assign |
Signed-off-by: zhengjiajin <zhengjiajin@pingcap.com>
efcc15e
to
74cd43b
Compare
done, ptal |
@breeswish: In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 74cd43b
|
/test idc-jenkins-ci-pd/integration-common-test |
/run-all-tests |
/run-integration-common-test |
1 similar comment
/run-integration-common-test |
cherry-pick #3389 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In pd repo: git pr https://github.com/tikv/pd/pull/3398
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Many users(come from DBaaS、operator、tiup) monitor multiple TiDB clusters in one Grafana, this PR make Grafana dashboards support multiple clusters and not affect single cluster usage. Cluster variable is hidden by default.
What is changed and how it works?
How it Works:
load it to your Grafana :))
Single Cluster:
No change
Multiple Cluster:
Construct a label that can uniquely identify the cluster. in tidb_operator, you can use {namespace}-{cluster_name} as your {tidb_cluster} variable.
add this configuration to your prometheus config
Check List
Tests
Code changes
Side effects
Related changes
Release note