New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project4: KvStore set method directly write key value to the file #462

Open

zilong-dai opened this issue Nov 24, 2023 · 0 comments

Labels

zilong-dai commented Nov 24, 2023

Should we first check if the key exists?

    fn set(&self, key: String, value: String) -> Result<()> {
        if let Some(_) = self.index.get(&key) {
            return Ok(());
        } 
        self.writer.lock().unwrap().set(key, value)
    }

zilong-dai added the type/question label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment