Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reparo/:Add worker-count, txn-batch config (#742) #746

Merged

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Sep 9, 2019

What problem does this PR solve?

cherry-pick #742
TOOL-1547
Add worker count and txn batch config for reparo. Users can decide these indecies themselves to change the sync speed of reparo.

What is changed and how it works?

Expose worker count and txn batch to config.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu lichunzhu changed the title add new config for worker count and txn batch in both toml files and … reparo/:Add worker-count, txn-batch config (#742) Sep 9, 2019
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu merged commit 9763c33 into pingcap:release-2.1 Sep 9, 2019
@lichunzhu lichunzhu deleted the czli/release2.1/reparo/addWorkerTxn branch September 9, 2019 06:39
@huynhphuong10284
Copy link

Just ask a question about "txn-batch" (default = 20) as below:

  • If my system is big data, it has an issue that data will be delayed for a long time.
  • If my system is small data, this value may be impacted to data delays.

The concern is "how to define a good value for any case in my system?"

@lichunzhu
Copy link
Contributor Author

@huynhphuong10284 It's not easy to "define a good value for any case in my system". For most of the time the default setting is enough. If you found that the latency is too high you can try increasing worker-count. If it doesn't work you can ask help from us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants