Add sync mode config to allow mismatch column number #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when setting SyncPartialColumn will allow mismatch column number and relax sql mode by removing STRICT_TRANS_TABLES.
july2993
changed the title
suzaku
reviewed
Jan 9, 2020
| @@ -55,6 +56,27 @@ func NewMysqlSyncer(cfg *DBConfig, tableInfoGetter translator.TableInfoGetter, w | |||
| })) | |||
| } | |||
|
|
|||
| if cfg.SyncMode != 0 { | |||
| mode := loader.SyncMode(cfg.SyncMode) | |||
There was a problem hiding this comment.
Can we make sure sqlMode don't include STRICT_TRANS_TABLES before creating db?
There was a problem hiding this comment.
if sqlMode is not configred we need to create db first by checking the sql mode default of the database.
description of pr updated |
|
/run-all-tests |
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Jan 15, 2020
allow when the column number of downstream table mismatch with current schema. For the case bidirectional replication, we will execute the DDL at one side, for add or drop column the column number will mismatch. cluster A <-> cluster B drop column of table t at cluster A some DML of table t at cluster B will miss the column dropped compared to cluster A
Merged
july2993
added a commit
that referenced
this pull request
Jan 15, 2020
* Add sync mode config (#867) allow when the column number of downstream table mismatch with current schema. For the case bidirectional replication, we will execute the DDL at one side, for add or drop column the column number will mismatch. cluster A <-> cluster B drop column of table t at cluster A some DML of table t at cluster B will miss the column dropped compared to cluster A * binlog loop back sync (#879) In the AA dual activity scenario, there is data write (DML) on both sides. The data of tidb cluster on both sides needs to be synchronized with each other，but avoid loopback synchronization，and ddl is only writed one side. add three variables in drainer.toml as identification to confirm need sync ddl or not and need set sync mark identification or not and sync identification id to Avoid loopback synchronization add configuration item loopback-control (true/false) set mark table identification or not and filter txn by mark table ddl-sync (true/false) sync ddl to downstream DB or not channel-id (integer) sync identification id，avoid loopback synchronization Co-authored-by: Nihao123451 <37206498+Nihao123451@users.noreply.github.com> Co-authored-by: freemindLi <59459626+freemindLi@users.noreply.github.com> Co-authored-by: Nihao123451 <37206498+Nihao123451@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
allow when the column number of downstream table mismatch with current schema.
For the case bidirectional replication, we will execute the DDL at one side, for add or drop column
the column number will mismatch.
cluster A <-> cluster B
tat cluster Atat cluster B will miss the column dropped compared to cluster AWhat is changed and how it works?
Add a config item
sync-modewhen setting SyncPartialColumn will allow mismatch column number
and relax sql mode by removing STRICT_TRANS_TABLES.
Check List
Tests
Code changes
Side effects
Related changes