Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Commit

Permalink
config: remove strict mode from default SQL mode (#316)
Browse files Browse the repository at this point in the history
* config: remove strict mode from default SQL mode

* tests: fixed typo
  • Loading branch information
kennytm authored May 11, 2020
1 parent c10636e commit 18cd93c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lightning/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ func NewConfig() *Config {
Host: "127.0.0.1",
User: "root",
StatusPort: 10080,
StrSQLMode: mysql.DefaultSQLMode,
StrSQLMode: "ONLY_FULL_GROUP_BY,NO_AUTO_CREATE_USER",
MaxAllowedPacket: defaultMaxAllowedPacket,
BuildStatsConcurrency: 20,
DistSQLScanConcurrency: 100,
Expand Down
2 changes: 2 additions & 0 deletions tests/sqlmode/on.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[tidb]
sql-mode = 'STRICT_TRANS_TABLES'

0 comments on commit 18cd93c

Please sign in to comment.