add partition table testcase

pingcap · Jan 10, 2023 · 21f3009 · 21f3009
1 parent 5df51d5
commit 21f3009
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/executor/historical_stats_test.go b/executor/historical_stats_test.go
@@ -292,9 +292,11 @@ PARTITION p0 VALUES LESS THAN (6)
 	tblID = hsWorker.GetOneHistoricalStatsTable()
 	require.NotEqual(t, tblID, -1)
 	err = hsWorker.DumpHistoricalStats(tblID, h)
+	require.NoError(t, err)
 	tblID = hsWorker.GetOneHistoricalStatsTable()
 	require.NotEqual(t, tblID, -1)
 	err = hsWorker.DumpHistoricalStats(tblID, h)
+	require.NoError(t, err)
 	time.Sleep(1 * time.Second)
 	snapshot = oracle.GoTimeToTS(time.Now())
 	jsTable, err = h.DumpHistoricalStatsBySnapshot("test", tbl.Meta(), snapshot)

diff --git a/statistics/handle/dump.go b/statistics/handle/dump.go
@@ -175,7 +175,9 @@ func (h *Handle) DumpHistoricalStatsBySnapshot(dbName string, tableInfo *model.T
 	if isDynamicMode {
 		tbl, err := h.tableHistoricalStatsToJSON(tableInfo.ID, snapshot)
 		if err != nil {
-			logutil.BgLogger().Warn("dump global historical stats failed", zap.Int64("table-id", tableInfo.ID))
+			logutil.BgLogger().Warn("dump global historical stats failed",
+				zap.Int64("table-id", tableInfo.ID),
+				zap.String("table-name", tableInfo.Name.String()))
 		} else if tbl != nil {
 			jsonTbl.Partitions["global"] = tbl
 		}