Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticlient doesn't make request in a round-robin fashion any more #10037

Closed
BusyJay opened this issue Apr 4, 2019 · 2 comments · Fixed by #10256
Closed

ticlient doesn't make request in a round-robin fashion any more #10037

BusyJay opened this issue Apr 4, 2019 · 2 comments · Fixed by #10256
Assignees
@lysu
Labels
type/new-feature

Comments

@BusyJay
Copy link
Contributor

BusyJay commented Apr 4, 2019

In the past, ticlient will try to make requests to all the followers when leader is unable to be connected. But due to #6880, it will not try to connect followers anymore.

Note that the a region can still elect a new leader and serve requests within the isolation of PD. So just depending on information in PD may keep TiDB out of service for an unnecessary long time in extreme conditions.
@shenli
Copy link
Member

shenli commented Apr 4, 2019

@jackysp @tiancaiamao PTAL

@BusyJay
Copy link
Contributor Author

BusyJay commented Apr 4, 2019

Actually it's an old feature that was removed. 🤣

@lysu lysu self-assigned this Apr 10, 2019
@lysu lysu mentioned this issue Apr 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lysu lysu

Labels
type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tikvclient: refine region-cache
3 participants
@lysu @shenli @BusyJay