Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the time zone variable instead of local time #13791

Closed
gregwebs opened this issue Nov 27, 2019 · 2 comments
Closed

use the time zone variable instead of local time #13791

gregwebs opened this issue Nov 27, 2019 · 2 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/bug The issue is confirmed as a bug.

Comments

@gregwebs
Copy link
Contributor

Bug Report

There are 5 places in the code base that use gotime.Local. If any of these is correct, we can add a comment explaining why. If they are not correct, they should be switched to reference the time zone setting. A user has already contributed a PR to fix one instance: #13752

@shenli this is a possible source of user reporte timezone issues.
@gregwebs gregwebs added the type/bug The issue is confirmed as a bug. label Nov 27, 2019
@Rustin170506
Copy link
Member

I will fix it one by one. #13626

@bb7133 bb7133 added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 28, 2019
@gregwebs
Copy link
Contributor Author

duplicate of #13626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregwebs @bb7133 @Rustin170506