Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: Migrate the infoschema's retrieving data logic for sys table to executor #14828

Closed
17 tasks done
reafans opened this issue Feb 18, 2020 · 3 comments
Closed
17 tasks done
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.

Comments

@reafans
Copy link
Contributor

reafans commented Feb 18, 2020

Feature Request

Is your feature request related to a problem? Please describe:

The infoschema pkg in TiDB is a SQL Meta-information module, In addition, all operations for Information Schema would access here. However, it contains too much logic for retrieving data like the dataForTableXXX() func, and these operations should have be put in the executor pkg.
relateds to #14704

Describe the feature you'd like:

We need to migrate these retrieving data logic to the executor pkg so that infoshema only contains schema meta information.
There are some other func of retrieving data in infoschema/tables.go :

  • dataForTables()
  • dataForIndexes()
  • dataForColumns()
  • dataForStatistics()
  • dataForCharacterSets()
  • dataForCollations()
  • dataForSessionVar()
  • dataForTableConstraints()
  • dataForPseudoProfiling()
  • dataForPartitions()
  • dataForKeyColumnUsage()
  • dataForUserPrivileges()
  • dataForEngines()
  • dataForCollationCharacterSetApplicability()
  • dataForProcesslist()
  • dataForTiDBHotRegions()
  • dataForTiKVStoreStatus()

...

migrate these logic and related test to executor/infoschema_reader.go , you can refer to the migration of dataForSchemata() and dataForSchemata() in #14704

Teachability, Documentation, Adoption, Migration Strategy:

Any questions for information_schema could you refer to MySQL 8.0 doc (information_schema)

@reafans reafans added the type/enhancement The issue or PR belongs to an enhancement. label Feb 18, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 19, 2020

Dear contributor, the first Performance challenge program has been closed. But you can still contribute to this issue and we appreciate your contribution.

2 similar comments
@sre-bot
Copy link
Contributor

sre-bot commented Feb 19, 2020

Dear contributor, the first Performance challenge program has been closed. But you can still contribute to this issue and we appreciate your contribution.

@sre-bot
Copy link
Contributor

sre-bot commented Feb 19, 2020

Dear contributor, the first Performance challenge program has been closed. But you can still contribute to this issue and we appreciate your contribution.

@pingcap pingcap deleted a comment from sre-bot Feb 20, 2020
@crazycs520 crazycs520 added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 20, 2020
@zimulala zimulala added component/DDL help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. component/DDL-need-LGT3 labels Feb 21, 2020
This was referenced Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants