Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement testkits for server tests #26108

Closed
Tracked by #26022
tisonkun opened this issue Jul 10, 2021 · 3 comments
Closed
Tracked by #26022

Implement testkits for server tests #26108

tisonkun opened this issue Jul 10, 2021 · 3 comments

Comments

@tisonkun
Copy link
Contributor

No description provided.

@jyz0309
Copy link
Contributor

jyz0309 commented Jul 11, 2021

Does this mean that we need to re-implement a TestKit and let it gradually replace utils/testkit? Or just make changes to the original testkit?
A little concern, now testkit is used by many test. If we make changes to the original testkit directly, this is a big change.

@tisonkun
Copy link
Contributor Author

tisonkun commented Jul 12, 2021

Hi @jyz0309 ! Thanks for your interest. I'm going to choose

  • re-implement a TestKit and let it gradually replace utils/testkit

That is in the plan and we will create testkit with go testing & testify. We use go-check for matchers almost and it won't be too complex. #26022 (comment)

@tisonkun
Copy link
Contributor Author

Fixed by a series of PR referred above. With #26712 merged, what we have to do is only migrating tests and add few methods of Result or TestKit on demand.

Closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants