Join partition table with normal table will cause error: invalid memory address or nil pointer dereference #26250

lcwangchao · 2021-07-14T13:06:33Z

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

create table tp (id int primary key) partition by range (id) (partition p0 values less than (100));
create table tn (id int primary key);
insert into tp values(1),(2);
insert into tn values(1),(2);

select * from tp,tn where tp.id=tn.id and tn.id=1 for update;

2. What did you expect to see? (Required)

No error

3. What did you see instead (Required)

mysql> select * from tp,tn where tp.id=tn.id and tn.id=1 for update;
ERROR 1105 (HY000): runtime error: invalid memory address or nil pointer dereference

4. What is your TiDB version? (Required)

master

The text was updated successfully, but these errors were encountered:

XuHuaiyu · 2021-07-15T02:44:03Z

[2021/07/15 10:42:05.376 +08:00] [ERROR] [misc.go:89] ["panic in the recoverable goroutine"] [r="\"invalid memory address or nil pointer dereference\""] ["stack trace"="github.com/pingcap/tidb/util.WithRecovery.func1\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/util/misc.go:91\nruntime.gopanic\n\t/Users/xuhuaiyu/.gvm/gos/go1.16/src/runtime/panic.go:965\nruntime.panicmem\n\t/Users/xuhuaiyu/.gvm/gos/go1.16/src/runtime/panic.go:212\nruntime.sigpanic\n\t/Users/xuhuaiyu/.gvm/gos/go1.16/src/runtime/signal_unix.go:734\ngithub.com/pingcap/parser/model.(*ColumnInfo).GetOriginDefaultValue\n\t/Users/xuhuaiyu/Development/GOPATH/pkg/mod/github.com/pingcap/parser@v0.0.0-20210707071004-31c87e37af5c/model/model.go:158\ngithub.com/pingcap/tidb/table.GetColOriginDefaultValue\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/table/column.go:484\ngithub.com/pingcap/tidb/executor.NewRowDecoder.func2\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/builder.go:4167\ngithub.com/pingcap/tidb/util/rowcodec.(*ChunkDecoder).DecodeToChunk\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/util/rowcodec/decoder.go:240\ngithub.com/pingcap/tidb/executor.DecodeRowValToChunk\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/point_get.go:517\ngithub.com/pingcap/tidb/executor.(*PointGetExecutor).Next\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/point_get.go:301\ngithub.com/pingcap/tidb/executor.Next\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/executor.go:286\ngithub.com/pingcap/tidb/executor.(*HashJoinExec).fetchBuildSideRows\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/join.go:268\ngithub.com/pingcap/tidb/executor.(*HashJoinExec).fetchAndBuildHashTable.func2\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/join.go:702\ngithub.com/pingcap/tidb/util.WithRecovery\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/util/misc.go:94"]
[2021/07/15 10:42:05.378 +08:00] [INFO] [conn.go:995] ["command dispatched failed"] [conn=3] [connInfo="id:3, addr:127.0.0.1:54951 status:10, collation:utf8_general_ci, user:root"] [command=Query] [status="inTxn:0, autocommit:1"] [sql="select * from tp,tn where tp.id=tn.id and tn.id=1 for update"] [txn_mode=OPTIMISTIC] [err="runtime error: invalid memory address or nil pointer dereference\ngithub.com/pingcap/tidb/executor.(*HashJoinExec).fetchAndBuildHashTable.func3\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/join.go:706\ngithub.com/pingcap/tidb/util.WithRecovery.func1\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/util/misc.go:86\nruntime.gopanic\n\t/Users/xuhuaiyu/.gvm/gos/go1.16/src/runtime/panic.go:965\nruntime.panicmem\n\t/Users/xuhuaiyu/.gvm/gos/go1.16/src/runtime/panic.go:212\nruntime.sigpanic\n\t/Users/xuhuaiyu/.gvm/gos/go1.16/src/runtime/signal_unix.go:734\ngithub.com/pingcap/parser/model.(*ColumnInfo).GetOriginDefaultValue\n\t/Users/xuhuaiyu/Development/GOPATH/pkg/mod/github.com/pingcap/parser@v0.0.0-20210707071004-31c87e37af5c/model/model.go:158\ngithub.com/pingcap/tidb/table.GetColOriginDefaultValue\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/table/column.go:484\ngithub.com/pingcap/tidb/executor.NewRowDecoder.func2\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/builder.go:4167\ngithub.com/pingcap/tidb/util/rowcodec.(*ChunkDecoder).DecodeToChunk\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/util/rowcodec/decoder.go:240\ngithub.com/pingcap/tidb/executor.DecodeRowValToChunk\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/point_get.go:517\ngithub.com/pingcap/tidb/executor.(*PointGetExecutor).Next\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/point_get.go:301\ngithub.com/pingcap/tidb/executor.Next\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/executor.go:286\ngithub.com/pingcap/tidb/executor.(*HashJoinExec).fetchBuildSideRows\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/join.go:268\ngithub.com/pingcap/tidb/executor.(*HashJoinExec).fetchAndBuildHashTable.func2\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/executor/join.go:702\ngithub.com/pingcap/tidb/util.WithRecovery\n\t/Users/xuhuaiyu/Development/GOPATH/src/github.com/pingcap/tidb/util/misc.go:94\nruntime.goexit\n\t/Users/xuhuaiyu/.gvm/gos/go1.16/src/runtime/asm_amd64.s:1371"]

qw4990 · 2021-07-15T08:09:08Z

caused by #21148

ti-srebot · 2021-07-20T09:31:38Z

Please edit this comment or add a new comment to complete the following information

Not a bug

Remove the 'type/bug' label
Add notes to indicate why it is not a bug

Duplicate bug

Add the 'type/duplicate' label
Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

When handling select for update and adding extra partition column, do not consider there might be non-partition table.
Lack of testing to cover that case.

2. Symptom (optional)

invalid memory address or nil pointer dereference

3. All Trigger Conditions (optional)

select for update, on normal table join partition table

4. Workaround (optional)

N/A

5. Affected versions

[v5.0.0:v5.0.x], [v5.1.0:v5.1.x]

6. Fixed versions

master

ti-srebot · 2021-07-20T09:40:22Z

( AffectedVersions ) fields are empty.
The values in ( AffectedVersions ) fields are incorrect.

ti-srebot · 2021-07-20T09:41:12Z

( AffectedVersions ) fields are empty.
The values in ( AffectedVersions ) fields are incorrect.

ti-srebot · 2021-07-20T09:42:00Z

( AffectedVersions ) fields are empty.
The values in ( AffectedVersions ) fields are incorrect.

lcwangchao added the type/bug The issue is confirmed as a bug. label Jul 14, 2021

lcwangchao changed the title ~~Normal table join partition table will cause error: invalid memory address or nil pointer dereference~~ Join partition table with normal table will cause error: invalid memory address or nil pointer dereference Jul 14, 2021

ChenPeng2013 added severity/major sig/execution SIG execution labels Jul 14, 2021

ichn-hu mentioned this issue Jul 15, 2021

Welcome to contribute #20804

Closed

lcwangchao mentioned this issue Jul 15, 2021

Join partition table with normal table for update should lock normal table but not #26251

Closed

tiancaiamao self-assigned this Jul 20, 2021

tiancaiamao mentioned this issue Jul 20, 2021

planner/core: fix a panic when select for update on join partition table with normal table #26373

Merged

12 tasks

ti-chi-bot closed this as completed in #26373 Jul 20, 2021

ti-srebot added the need-more-info label Jul 20, 2021

tiancaiamao added the component/executor label Jul 20, 2021

ti-srebot removed the need-more-info label Jul 20, 2021

seiya-annie mentioned this issue Jul 26, 2021

v4.0.1 upgrade to 4.0.14, panic in the recoverable goroutine, report invalid memory address or nil pointer dereference #26266

Closed

ti-srebot mentioned this issue Jul 26, 2021

planner/core: fix a panic when select for update on join partition table with normal table (#26373) #26563

Merged

12 tasks

tiancaiamao mentioned this issue Jul 29, 2021

planner,executor: fix 'select ...(join on partition table) for update' panic (#21148) #25845

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Join partition table with normal table will cause error: invalid memory address or nil pointer dereference #26250

Join partition table with normal table will cause error: invalid memory address or nil pointer dereference #26250

lcwangchao commented Jul 14, 2021

XuHuaiyu commented Jul 15, 2021

qw4990 commented Jul 15, 2021

ti-srebot commented Jul 20, 2021 •

edited by tiancaiamao

Loading

ti-srebot commented Jul 20, 2021

ti-srebot commented Jul 20, 2021

ti-srebot commented Jul 20, 2021

Join partition table with normal table will cause error: invalid memory address or nil pointer dereference #26250

Join partition table with normal table will cause error: invalid memory address or nil pointer dereference #26250

Comments

lcwangchao commented Jul 14, 2021

Bug Report

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

XuHuaiyu commented Jul 15, 2021

qw4990 commented Jul 15, 2021

ti-srebot commented Jul 20, 2021 • edited by tiancaiamao Loading

Please edit this comment or add a new comment to complete the following information

Not a bug

Duplicate bug

Bug

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

ti-srebot commented Jul 20, 2021

ti-srebot commented Jul 20, 2021

ti-srebot commented Jul 20, 2021

ti-srebot commented Jul 20, 2021 •

edited by tiancaiamao

Loading