Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate test-infra to testify for statistics #27141

Closed
16 tasks done
Tracked by #26022
tisonkun opened this issue Aug 12, 2021 · 9 comments · Fixed by #32135
Closed
16 tasks done
Tracked by #26022

migrate test-infra to testify for statistics #27141

tisonkun opened this issue Aug 12, 2021 · 9 comments · Fixed by #32135
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement

Comments

@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 12, 2021
@feitian124
Copy link
Contributor

/assign

@feitian124
Copy link
Contributor

knowlege about statistics
pingcap/tidb-dev-guide#70

@feitian124
Copy link
Contributor

feitian124 commented Sep 8, 2021

hi @tisonkun , please split this task to sub tasks for me

@tisonkun
Copy link
Contributor Author

@feitian124 ok. Do you have a plan how to split the tasks? In files?

@feitian124
Copy link
Contributor

ok, it is fine.
2 small files and 2 large files, you can adjust.

❯ find statistics -name "*_test.go" -exec sh -c '[ -f "$0" ] && printf "%6s\t\t%s\n" "$(wc -l<"$0")" "$0"' {} \;
    42          statistics/analyze_jobs_test.go
   308          statistics/sample_test.go
   316          statistics/feedback_test.go
   264          statistics/scalar_test.go
   467          statistics/histogram_test.go
   108          statistics/fmsketch_test.go
   483          statistics/integration_test.go
   715          statistics/statistics_test.go
   307          statistics/cmsketch_test.go
   264          statistics/handle/ddl_test.go
  3075          statistics/handle/handle_test.go
  2331          statistics/handle/update_test.go
   136          statistics/handle/gc_test.go
    50          statistics/handle/update_list_test.go
   340          statistics/handle/dump_test.go
   966          statistics/selectivity_test.go

@tisonkun
Copy link
Contributor Author

ok. I will create all these files for you. You can assign them to yourself.

@feitian124
Copy link
Contributor

cheers 🎉
statistics are almost done, next step is statistics/handle, hopefully finish in 2 weeks.
after that, i wish could allocate some time to do none-test-migrate tasks besides migrate tasks.

@tisonkun

@feitian124
Copy link
Contributor

there are still lots todo, 325 todo, 736 in total, in which about 30 cases are from parser package.

❯ find . -name "*_test.go" -not -path "./vendor/*"  | xargs grep "github.com/pingcap/check" | wc -l
325
❯ find . -name "*_test.go" -not -path "./vendor/*"  | wc -l
736

❯ find parser -name "*_test.go"   | wc -l
30
❯ find parser -name "*_test.go"   | xargs grep "github.com/pingcap/check" | wc -l
27

@tisonkun
Copy link
Contributor Author

@feitian124 yes. We may need more contributors & committers to work on the remaining packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants