-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate test-infra to testify for statistics
#27141
Comments
/assign |
knowlege about statistics |
hi @tisonkun , please split this task to sub tasks for me |
@feitian124 ok. Do you have a plan how to split the tasks? In files? |
ok, it is fine. ❯ find statistics -name "*_test.go" -exec sh -c '[ -f "$0" ] && printf "%6s\t\t%s\n" "$(wc -l<"$0")" "$0"' {} \;
42 statistics/analyze_jobs_test.go
308 statistics/sample_test.go
316 statistics/feedback_test.go
264 statistics/scalar_test.go
467 statistics/histogram_test.go
108 statistics/fmsketch_test.go
483 statistics/integration_test.go
715 statistics/statistics_test.go
307 statistics/cmsketch_test.go
264 statistics/handle/ddl_test.go
3075 statistics/handle/handle_test.go
2331 statistics/handle/update_test.go
136 statistics/handle/gc_test.go
50 statistics/handle/update_list_test.go
340 statistics/handle/dump_test.go
966 statistics/selectivity_test.go |
ok. I will create all these files for you. You can assign them to yourself. |
cheers 🎉 |
there are still lots todo, ❯ find . -name "*_test.go" -not -path "./vendor/*" | xargs grep "github.com/pingcap/check" | wc -l
325
❯ find . -name "*_test.go" -not -path "./vendor/*" | wc -l
736
❯ find parser -name "*_test.go" | wc -l
30
❯ find parser -name "*_test.go" | xargs grep "github.com/pingcap/check" | wc -l
27
|
@feitian124 yes. We may need more contributors & committers to work on the remaining packages. |
statistics/analyze_jobs_test.go
#28116statistics/sample_test.go
#28117statistics/feedback_test.go
#28118statistics/scalar_test.go
#28119statistics/histogram_test.go
#28120statistics/fmsketch_test.go
#28121statistics/integration_test.go
#28122statistics/statistics_test.go
#28123statistics/cmsketch_test.go
#28124statistics/handle/ddl_test.go
#28125statistics/handle/handle_test.go
#28126statistics/handle/update_test.go
#28127statistics/handle/gc_test.go
#28128statistics/handle/update_list_test.go
#28129statistics/handle/dump_test.go
#28130statistics/selectivity_test.go
#28131The text was updated successfully, but these errors were encountered: