Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for bindinfo pkg #27177

Closed
Tracked by #26022
tisonkun opened this issue Aug 13, 2021 · 6 comments · Fixed by #28469
Closed
Tracked by #26022

migrate test-infra to testify for bindinfo pkg #27177

tisonkun opened this issue Aug 13, 2021 · 6 comments · Fixed by #28469
Assignees
@w169q169
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

No description provided.

@tisonkun tisonkun mentioned this issue Aug 13, 2021
Closed
53 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 13, 2021
@w169q169
Copy link
Contributor

/assign

@tisonkun
Copy link
Contributor Author

tisonkun commented Sep 1, 2021

Hi @w169q169 , is there any progress on this issue?

@w169q169
Copy link
Contributor

w169q169 commented Sep 2, 2021 •
edited
Loading

Hi @w169q169 , is there any progress on this issue?

I'm working on it, but this package need too much work (65 test func and 417 assert statements). My plan is submitting changes in several stages(may be 4-5 pr).

  1. split into serveral file(origin test file is too big and new tests is added on the same time)
  2. migrate some old tests in old file(bind_test.go) to new file
  3. submit a pr
  4. repeat step-2,step-3

@tisonkun
Copy link
Contributor Author

tisonkun commented Sep 3, 2021

@w169q169 thanks for your updates! That makes sense for me. Yes I'd like to split into multiple test files also. Please let me know when you create the first PR. And ask for me updating the issue description if necessary.

@w169q169 w169q169 mentioned this issue Sep 7, 2021
Merged
This was referenced Sep 15, 2021
Merged
Merged
@tisonkun
Copy link
Contributor Author

@w169q169 hi! I'd like to take the part of testSerialSuite so that we get rid of one of the suites.

@tisonkun tisonkun mentioned this issue Sep 27, 2021
Merged
@w169q169
Copy link
Contributor

@tisonkun okay, you do the part of testSerialSuite as your wish . I will continue the remaining part.

@w169q169 w169q169 mentioned this issue Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w169q169 w169q169

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bindinfo: migrate test-infra to testify(staging-4) w169q169/tidb
2 participants
@w169q169 @tisonkun