New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop index operation on hash partitioned table #8378

Closed

tiancaiamao opened this issue Nov 21, 2018 · 1 comment

Labels

type/enhancement

Contributor

tiancaiamao commented Nov 21, 2018 •

edited

Loading

Feature Request

Here is the entrance of DropIndex: https://github.com/pingcap/tidb/blob/master/ddl/ddl_api.go#L2111
The a new DDL job is created and put the the job queue https://github.com/pingcap/tidb/blob/master/ddl/ddl_worker.go#L188
https://github.com/pingcap/tidb/blob/master/ddl/ddl_worker.go#L331
The DDL worker will handle the job here:
https://github.com/pingcap/tidb/blob/master/ddl/ddl_worker.go#L494

Drop index on a hash partitioned table should take into consideration the the table is hash partitioned, drop index data of all the partitions.

Teachability, Documentation, Adoption, Migration Strategy:

Maybe useful:
ddl:support drop index for the partitioned table #7306
https://github.com/pingcap/tidb/blob/master/docs/design/2018-10-19-table-partition.md
https://pingcap.com/blog-cn/tidb-source-code-reading-20/

tiancaiamao mentioned this issue

Support for table partition #7907

Closed

12 tasks

morgo added the type/enhancement label

Contributor

zimulala commented Feb 13, 2020

@tiancaiamao Could we close this issue?

tiancaiamao closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment