Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: give the full schema information when group by fields not exists (#11406) #11455

Merged
merged 7 commits into from
Aug 6, 2019
Merged

planner/core: give the full schema information when group by fields not exists (#11406) #11455

merged 7 commits into from
Aug 6, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 26, 2019

cherry-pick #11406 to release-3.0

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 26, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jul 26, 2019
Merged
@sre-bot sre-bot added sig/planner SIG: Planner contribution This PR is from a community contributor. type/3.0 cherry-pick labels Jul 26, 2019
zz-jason
zz-jason reviewed Jul 26, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested review from winoros and alivxxx August 1, 2019 05:02
@alivxxx alivxxx requested review from SunRunAway and removed request for alivxxx August 6, 2019 07:55
SunRunAway
SunRunAway approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Aug 6, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 6, 2019

/run-all-tests

@sre-bot sre-bot merged commit 8642e9b into pingcap:release-3.0 Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sre-bot @SunRunAway @zz-jason @gaoxingliang @bb7133 @alivxxx