-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema, session: support for events_statements_summary_by_digest #12017
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d668844
some implementation for statement summary
djshow832 ecc243c
a demo for statement summary
djshow832 43c91af
add MaxSqlLength limit for sampleSQL in stmtSummary
djshow832 31d4612
Add test cases for stmtSummary.
djshow832 60c3c76
remove duplicate code for table_test.go
djshow832 250e762
Revert "remove duplicate code for table_test.go"
djshow832 a144b7b
Add a test case for events_statements_summary_by_digest
djshow832 c5d2178
format the code in tables_test.go
djshow832 e6d1865
rename variable names for StmtSummary.
djshow832 6c8b6e6
remove ineffectual assignment in statement_summary_test
djshow832 122af57
tidb_enable_stmt_summary can only be a global variable
djshow832 37ebb33
add test cases for statement summary.
djshow832 3706cb0
set default of tidb_enable_stmt_summary to True to enable benchmark t…
djshow832 0b9ed23
format import in tables_test
djshow832 b0e1f0f
change the year in copyright to 2019.
djshow832 bb82da5
format import in util/stmtsummary/statement_summary_test.go
djshow832 2482938
format imports in tables.go
djshow832 6a3d209
remove debugging print in tables.go
djshow832 02cedb1
add a separate lock for each summary entry
djshow832 681e099
remove unsupported methods from perfSchemaTable
djshow832 9dfb973
use Mutex in stmtSummaryByDigest instead of RWMutex
djshow832 8b2b298
rename class names related to statement summary
djshow832 f60ad41
clear events_statement_summary_by_digest when tidb_enable_stmt_summar…
djshow832 2fde3ad
remove sysvar_observers to simplify code
djshow832 06beeac
modify TestStmtSummaryTable to avoid copying lock value
djshow832 5e59a41
rephrase comments for statement summary
djshow832 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we should resurrect perf_schema, maybe we can put it to info_schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some table names are the same, like tables.go.
And performance schema is independent with information schema in MySQL.
So I prefer the directory to be like this:
--virtual_table
----infoschema
----perfschema
----sys
But now, I prefer not to change the directory structure in this PR. Maybe fixing it in another PR is better, if needed.