tidb-server: introduce go.uber.org/automaxprocs
#13340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13340 +/- ##
===========================================
Coverage 80.1608% 80.1608%
===========================================
Files 469 469
Lines 112626 112626
===========================================
Hits 90282 90282
Misses 15384 15384
Partials 6960 6960 |
tennix
changed the title
|
LGTM |
|
@tennix according to Commit Message and Pull Request Style, we should use |
tennix
changed the title
go.uber.org/automaxprocs
zz-jason
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 13354, 13209, 13166 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR closes #13337 to allow auto set
GOMAXPROCSto the CPUs tidb-server can use.What is changed and how it works?
Introducing the package
go.uber.org/automaxprocs, this package will read cgroup system to get the CPU the process can use and adjust theGOMAXPROCSto the CPU limit. When users already explicitly setperformance.max-procsto non-zero, then the value provided by users will override the default value, so it does not have break change.Check List
Tests
Run tidb-server inside a kubernetes pod which has cpu limit by
GODEBUG=schedtrace=1000 ./tidb-server, the reportedGOMAXPROCSis exactly the cpu limits set by pod resources.Code changes
None
Side effects
None
Related changes
Release note
Auto set GOMAXPROCS in Docker container environment.