Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinSysDateWithoutFspSig #13348

Merged
merged 6 commits into from
Nov 11, 2019
Merged

expression: implement vectorized evaluation for builtinSysDateWithoutFspSig #13348

merged 6 commits into from
Nov 11, 2019

Conversation

ekalinin
Copy link
Contributor

PCP #12101

What problem does this PR solve?

This PR implements vectorized builtinSysDateWithoutFspSig

What is changed and how it works?

➜ make vectorized-bench VB_FILE=Time VB_FUNC=builtinSysDateWithoutFspSig
cd ./expression && \
	go test -v -benchmem \
		-bench=BenchmarkVectorizedBuiltinTimeFunc \
		-run=BenchmarkVectorizedBuiltinTimeFunc \
		-args "builtinSysDateWithoutFspSig"
goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinTimeFuncGenerated-12    	1000000000	         0.00967 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinSysDateWithoutFspSig-VecBuiltinFunc-12         	  751180	      1467 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinSysDateWithoutFspSig-NonVecBuiltinFunc-12      	    6912	    177445 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/pingcap/tidb/expression	2.443s

Check List

Tests

  • Unit test
  • Integration test

@ekalinin ekalinin requested a review from a team as a code owner November 11, 2019 06:31
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@ghost ghost requested review from qw4990 and XuHuaiyu November 11, 2019 06:31
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 11, 2019
@ghost ghost removed their request for review November 11, 2019 06:31
@zyxbest
Copy link
Contributor

zyxbest commented Nov 11, 2019

/build

@codecov
Copy link

codecov bot commented Nov 11, 2019 •
edited
Loading

Codecov Report

Merging #13348 into master will decrease coverage by 0.4834%.
The diff coverage is 73.3333%.

@@               Coverage Diff                @@
##             master     #13348        +/-   ##
================================================
- Coverage   80.6345%   80.1511%   -0.4835%     
================================================
  Files           469        469                
  Lines        114250     112359      -1891     
================================================
- Hits          92125      90057      -2068     
- Misses        15169      15305       +136     
- Partials       6956       6997        +41

@Reminiscent
Copy link
Contributor

Please solve the conflicts, thanks!

XuHuaiyu
XuHuaiyu reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2019
qw4990
qw4990 approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

Your auto merge job has been accepted, waiting for 13363, 13328, 13363

@ngaut ngaut merged commit 838481a into pingcap:master Nov 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

@ekalinin complete task #12101 and get 50 score, currerent score 250.

@ekalinin ekalinin deleted the vec-builtinSysDateWithoutFspSig branch November 13, 2019 10:00
@ekalinin
Copy link
Contributor Author

Some related changes #13425

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@ekalinin @XiaTianliang
expression: implement vectorized evaluation for builtinSysDateWithout…
a8fc201 
…FspSig (pingcap#13348)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ekalinin @sre-bot @zyxbest @Reminiscent @qw4990 @XuHuaiyu @ngaut