executor, util: rename original List to ListInMemory and add a new interface List #13353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
reviewed
Nov 11, 2019
util/chunk/list.go
Outdated
| func NewList(fieldTypes []*types.FieldType, initChunkSize, maxChunkSize int) *List { | ||
| l := &List{ | ||
| // NewList creates a new ListInMemory with field types, init chunk size and max chunk size. | ||
| func NewList(fieldTypes []*types.FieldType, initChunkSize, maxChunkSize int) *ListInMemory { |
XuHuaiyu
changed the title
Codecov Report
@@ Coverage Diff @@
## master #13353 +/- ##
===========================================
Coverage 80.2193% 80.2193%
===========================================
Files 469 469
Lines 112610 112610
===========================================
Hits 90335 90335
Misses 15295 15295
Partials 6980 6980 |
XuHuaiyu
approved these changes
Nov 11, 2019
XuHuaiyu
added
component/util
status/LGT2
|
Your auto merge job has been accepted, waiting for 13330 |
|
/merge |
|
Your auto merge job has been accepted, waiting for 13330 |
|
/run-all-tests |
|
@fzhedu merge failed. |
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
…a new interface List (pingcap#13353)" (pingcap#13363) This reverts commit 2b5f81a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add a new interface to refactor code in #12882
What is changed and how it works?
Rename original
ListtoListInMemoryand add a new interfaceListCheck List
Tests
Code changes
Side effects
N/A
Related changes
N/A
Release note
N/A