ddl: fix ddl modify column from null to not null bug: check null value again before change to no null (#10948) #13533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e again before change to no null (pingcap#10948)
crazycs520
changed the title
|
How about cherry-picking #13223 together? |
bb7133
added
type/3.0 cherry-pick
status/LGT1
bb7133
requested changes
Nov 18, 2019
ddl/db_test.go
Outdated
| return | ||
| } | ||
| if times == 0 { | ||
| tk2.MustExec("insert into t1 values ();") |
There was a problem hiding this comment.
Please do not make assertions in hook function.
|
/run-all-tests |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick #10948