-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: fix wrong cherry-pick 3.0 #18292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kennytm,Thanks for you review. |
3 data races
|
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jackysp,Thanks for you review. |
@jackysp, Thanks for your review, however we are sorry that your vote won't be count. You already give a LGTM to this PR |
/merge |
Sorry @jackysp, you don't have permission to trigger auto merge event on this branch. |
/merge |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@HunDunDM,Thanks for you review. |
Related #17944 |
What problem does this PR solve?
Problem Summary:
CI failure in 3.0
What is changed and how it works?
Proposal: xxx
What's Changed,How it Works:
revert https://github.com/pingcap/tidb/pull/17944/files#diff-7a4a1f349a05c777732cb147db848c12L59
Related changes
Check List
Tests
Side effects
Release note
This change is